Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve go-ftw / Docker documentation #107

Open
theseion opened this issue Jan 9, 2024 · 0 comments
Open

Improve go-ftw / Docker documentation #107

theseion opened this issue Jan 9, 2024 · 0 comments
Assignees

Comments

@theseion
Copy link
Contributor

theseion commented Jan 9, 2024

Findings by @dune73:

  • I had to install docker-compose (Ubuntu 22.04). Docker compose command becomes docker-compose. The documentation explains the need for docker-compose in older installs, but it only explains this under go-ftw, not in the docker section, where I kind of expect such an explanation.
  • The code block uses > as prompt, while other code blocks use $.
  • The code block does not explain you need to be root to run this. sudo would probably make this easier. The twist is that you may not be root to install go-ftw afterwards or the binary can't be found for the testing user.
  • The docker ps is a bit hidden within the same code block as the compose.
  • I'm getting a go-httpbin container instead of the httpbin indicated in the docker ps output
  • The ftw files presented further down below in the documentation do not correspond with the docker container composed. That means you need to adjust the log file within the .ftw.yaml. The doc explains that we're mounting the log volumes, but it does not indicate the path and I had to look for it in the compose file without this being explained anywhere. We are providing docker-compose.yaml. Why don't we provide a preconfigured .ftw.apache.docker.yaml etc.?
@fzipi fzipi self-assigned this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants