Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo references #16

Merged
merged 1 commit into from Aug 4, 2020
Merged

Update repo references #16

merged 1 commit into from Aug 4, 2020

Conversation

shiz0
Copy link
Contributor

@shiz0 shiz0 commented Aug 2, 2020 •
edited

from archived
https://github.com/SpiderLabs/owasp-modsecurity-crs
to
https://github.com/coreruleset/coreruleset

I did a local test build of both Dockerfiles which finished without error.
Repo change seems to work correctly:

Initialized empty Git repository in /opt/owasp-crs/.git/
From https://github.com/coreruleset/coreruleset
 * branch            v3.3/dev   -> FETCH_HEAD
 * [new branch]      v3.3/dev   -> origin/v3.3/dev
Switched to a new branch 'v3.3/dev'
Branch 'v3.3/dev' set up to track remote branch 'v3.3/dev' from 'origin'.

should partly resolve #14

bittner
bittner approved these changes Aug 2, 2020
View reviewed changes
Copy link
Contributor

@bittner bittner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Side note: I figured that we We need to build the same image for the newer CRS version 3.4, too. I'll open a separate issue for that. This is addressed by PR #12.

REQUEST-900-EXCLUSION-RULES-BEFORE-CRS.conf Outdated Show resolved Hide resolved
RESPONSE-999-EXCLUSION-RULES-AFTER-CRS.conf Outdated Show resolved Hide resolved
@bittner bittner changed the title update repo references Update repo references Aug 2, 2020
@bittner
Copy link
Contributor

bittner commented Aug 2, 2020

@shiz0 Can you squash all your changes into a single commit in the end, please?

@shiz0 @bittner
Update repository links to coreruleset/coreruleset
5ccc37f 
update link to new repo location

update link to new repo location

Update Dockerfile

update repo to coreruleset/coreruleset

Updated to link latest development branch

Co-authored-by: Peter Bittner <django@bittner.it>

Updated to link latest development branch

Co-authored-by: Peter Bittner <django@bittner.it>
@shiz0
Copy link
Contributor Author

shiz0 commented Aug 3, 2020

I was unsure about the exclusion files, if they maybe were left at 3.2 intentionally.
Commited your proposals and squashed.

@bittner bittner merged commit e2f4bec into coreruleset:master Aug 4, 2020
@bittner
Copy link
Contributor

bittner commented Aug 4, 2020

Thanks @shiz0 for ironing this out! 🏅

@shiz0
Copy link
Contributor Author

shiz0 commented Aug 4, 2020

Happy to help. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bittner bittner bittner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sources?
2 participants
@shiz0 @bittner