This repository has been archived by the owner on Nov 26, 2022. It is now read-only.
Add environment variables (for both Apache and Nginx) #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srueg
suggested changes
Mar 10, 2020
zugao
force-pushed
the
feature/add-env-vars
branch
3 times, most recently
from
1b928fd
to
57a9315
Compare
bittner
suggested changes
Mar 11, 2020
bittner
force-pushed
the
feature/add-env-vars
branch
3 times, most recently
from
6b3df87
to
d429fd1
Compare
bittner
changed the title
To make the images more configurable
Modsecurity, Nginx and Apache
bittner
force-pushed
the
feature/add-env-vars
branch
from
0136661
to
a9c8bed
Compare
bittner
requested review from
srueg,
a team and
bittner
and removed request for
bittner
bittner
approved these changes
Mar 20, 2020
bittner
reviewed
Mar 20, 2020
bittner
changed the title
srueg
suggested changes
Mar 23, 2020
bittner
force-pushed
the
feature/add-env-vars
branch
from
7d2e23b
to
a9c8bed
Compare
srueg
suggested changes
Mar 25, 2020
|
LGTM also. Nice work! |
Add /healthz and /metrics endpoints to Nginx setup Harmonize variable naming across Apache and Nginx
srueg
approved these changes
Mar 27, 2020
|
@bittner Amazing job! |
|
Thanks! 👍 There's still a lot left to do. But yeah, one step after the other. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Apache and Nginx images. Added various ENV variables for modsecurity, apache and nginx in order to make the images easier to use out of the box.
Notes for reviewer
Some files have only whitespace changes (conversion of line endings); you may want to activate the "Hide whitespace changes" option.
Known issues
The request headers
X-Real-IP,X-Forwarded-For,X-Forwarded-Port,X-Forwarded-Protoare removed in Nginx (or their values blanked) before the request is passed to the$BACKENDviaproxy_pass $upstream;Hence the external behavior is not 100% guaranteed to be identical across the two webproxy flavors (Apache, Nginx), as far as the request headers on the backend are concerned. This is a very tricky, stubborn technical problem. I'll open an issue to follow up on that.