Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defaultVisible prop added #399

Closed
wants to merge 1 commit into from

Conversation

jpranays
Copy link

Added optional defaultVisible prop : If set true, then on initial render, dropdown menu is visible.

@mrholek
Copy link
Member

mrholek commented Jun 17, 2024

@jpranays, why don't you use a visible prop instead?

@jpranays
Copy link
Author

Since the main component already handles state logic for toggling, I believe there’s no necessity to duplicate it in the parent component. Additionally, I found it beneficial to include a defaultVisible option, akin to practices seen in other prominent libraries.
While using one of those libraries, I needed to pass down props but couldn’t locate the defaultVisible prop to match with.

@jpranays
Copy link
Author

Any update on this ?

@jpranays jpranays closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants