Improve charm_upgrade imports and remove test pprints

coreycb · Oct 26, 2023 · 1bb67ab · 1bb67ab
1 parent 0684a62
commit 1bb67ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/unit_tests/utilities/test_zaza_utilities_upgrade_utils.py b/unit_tests/utilities/test_zaza_utilities_upgrade_utils.py
@@ -14,7 +14,6 @@
 
 import copy
 import mock
-import pprint
 
 import unit_tests.utils as ut_utils
 import zaza.openstack.utilities.upgrade_utils as openstack_upgrade
@@ -96,8 +95,6 @@ def test_get_upgrade_groups(self):
             ('Data Plane', ['nova-compute']),
             ('sweep_up', [])]
         actual = openstack_upgrade.get_upgrade_groups()
-        pprint.pprint(expected)
-        pprint.pprint(actual)
         self.assertEqual(
             actual,
             expected)
@@ -111,8 +108,6 @@ def test_get_charm_upgrade_groups(self):
             ('Data Plane', ['nova-compute']),
             ('sweep_up', ['neutron-openvswitch', 'ntp'])]
         actual = openstack_upgrade.get_charm_upgrade_groups()
-        pprint.pprint(expected)
-        pprint.pprint(actual)
         self.assertEqual(
             actual,
             expected)
@@ -126,8 +121,6 @@ def test_get_series_upgrade_groups(self):
             ('Data Plane', ['nova-compute']),
             ('sweep_up', ['ntp'])]
         actual = openstack_upgrade.get_series_upgrade_groups()
-        pprint.pprint(expected)
-        pprint.pprint(actual)
         self.assertEqual(
             actual,
             expected)
@@ -141,8 +134,6 @@ def test_get_series_upgrade_groups(self):
             ('sweep_up', ['ntp'])]
         actual = openstack_upgrade.get_series_upgrade_groups(
             target_series='focal')
-        pprint.pprint(expected)
-        pprint.pprint(actual)
         self.assertEqual(
             actual,
             expected)

diff --git a/zaza/openstack/charm_tests/charm_upgrade/tests.py b/zaza/openstack/charm_tests/charm_upgrade/tests.py
@@ -22,8 +22,8 @@
 import zaza.model
 from zaza.openstack.utilities import (
     cli as cli_utils,
-    os_versions as os_versions,
-    upgrade_utils as upgrade_utils,
+    os_versions,
+    upgrade_utils,
 )