Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow get_schedule to be called without season param. #7

Closed
coreyjs opened this issue Oct 2, 2023 · 1 comment · Fixed by #8
Closed

Allow get_schedule to be called without season param. #7

coreyjs opened this issue Oct 2, 2023 · 1 comment · Fixed by #8
Assignees
@coreyjs
Labels
enhancement New feature or request

Comments

@coreyjs
Copy link
Owner

coreyjs commented Oct 2, 2023

This will allow the nhl api to default back to the current season if nothing is supplied. This makes it a little bit for flexible in a full time use case.
@coreyjs coreyjs added the enhancement New feature or request label Oct 2, 2023
@coreyjs coreyjs self-assigned this Oct 2, 2023
@coreyjs
Copy link
Owner Author

coreyjs commented Oct 2, 2023

I have a PR for this.

coreyjs added a commit that referenced this issue Oct 2, 2023
@coreyjs
Resolves #7 - Allows schedule.get_schedule() to default season to Non…
96809f3 
…e, which allows the API to use the current season. Updates the way the query is built for that method as well. Adds test coverage.
@coreyjs coreyjs mentioned this issue Oct 2, 2023
Merged
@coreyjs coreyjs closed this as completed in #8 Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coreyjs coreyjs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/7 coreyjs/nhl-api-py
1 participant
@coreyjs