Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Partial Support for the groups Argument for Convolutional Layers for 1.1.5 Release #105

Merged
merged 9 commits into from
Oct 7, 2021

Conversation

coreylammie
Copy link
Owner

  • Added partial support for the groups argument for convolutional layers.
  • Fixed patching procedure in memtorch.mn.module.patch_model and memtorch.bh.nonideality.apply_nonidealities to fix semantic error in Tutorial.ipynb.
  • Fixed import statement in Exemplar_Simulations.ipynb.
  • Further modularized patching logic in memtorch.bh.nonideality.NonIdeality and memtorch.mn.Module.
  • Modified default number of worker in memtorch.utils from 2 to 1.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #105 (3841f3c) into master (0dfdbe1) will increase coverage by 0.10%.
The diff coverage is 74.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   84.53%   84.63%   +0.10%     
==========================================
  Files          54       54              
  Lines        2269     2272       +3     
==========================================
+ Hits         1918     1923       +5     
+ Misses        351      349       -2     
Flag Coverage Δ
unittests 84.63% <74.28%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
memtorch/mn/Module.py 81.42% <69.23%> (-1.63%) ⬇️
memtorch/bh/nonideality/NonIdeality.py 96.00% <100.00%> (+8.50%) ⬆️
memtorch/mn/Conv1d.py 94.50% <100.00%> (-0.06%) ⬇️
memtorch/mn/Conv2d.py 93.68% <100.00%> (ø)
memtorch/mn/Conv3d.py 93.68% <100.00%> (-0.07%) ⬇️
memtorch/utils.py 86.66% <100.00%> (ø)
memtorch/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfdbe1...3841f3c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant