NCCL integration #146
Closed
NCCL integration #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool let me know when you're ready for a review or help! |
|
@coreylowman I added the result and safe implementations now. I'm still working on testing and documentation, but the meat of the work is there if you want to add any early comments. I'll mark this "ready for review" once I'm happy with the documentation and testing time this weekend. |
coreylowman
reviewed
May 15, 2023
|
Any work still happening here ? I'm really interested in using this. I can try and continue the PR if needed. We're working on this: https://github.com/LaurentMazare/candle and this might become interesting for unlocking LLM work. |
Merged
|
Thanks for the initial work on this @Thenerdstation. Merged in #164 which extended all the commits in this pr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft PR to get early feedback that I am doing the bindgen correctly. I am currently still working on the result and safe wrappings.
Fixes #129