Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add occupancy to driver::result #150

Merged
merged 2 commits into from
Jun 21, 2023
Merged

WIP: Add occupancy to driver::result #150

merged 2 commits into from
Jun 21, 2023

Conversation

tthebst
Copy link
Contributor

@tthebst tthebst commented May 16, 2023

Some questions:

How do you plan to return multiple values (cuOccupancyMaxPotentialBlockSize)?

How would the safe API look like?

@tthebst tthebst changed the title Add occupancy to driver::sys Add occupancy to driver::result May 16, 2023
@tthebst tthebst changed the title Add occupancy to driver::result WIP: Add occupancy to driver::result May 17, 2023
coreylowman
coreylowman approved these changes May 19, 2023
View reviewed changes
Copy link
Owner

@coreylowman coreylowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Happy to have the safe API be a separate PR.

I think the safe API would involve adding methods to the CudaFunction struct. It seems like most of the safety involves having a function that exists, which the safe api already covers.

@coreylowman
Copy link
Owner

Let me know if you want me to merge this, or if you want to add the safe API to this. If I don't hear from you I'll merge in a week

@tthebst
Copy link
Contributor Author

tthebst commented May 23, 2023

Okay. Let's merge this.

@coreylowman coreylowman merged commit b26fdf3 into coreylowman:main Jun 21, 2023
3 checks passed
@coreylowman
Copy link
Owner

Sweet, thanks for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreylowman coreylowman coreylowman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tthebst @coreylowman