Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented LaunchAsync for raw ptr arrays #204

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jafioti
Copy link
Contributor

@jafioti jafioti commented Feb 7, 2024

I'm working with runtime-generated kernels that can take in varying amounts of inputs. The number of inputs isn't known at compile time, so I build up a vec of c_void pointers to the inputs. This didn't work with launch, so I implemented LaunchAsync trait for arrays of pointers.

@jafioti jafioti mentioned this pull request Feb 7, 2024
4 tasks
@jafioti
Copy link
Contributor Author

jafioti commented Feb 23, 2024

@coreylowman Would you be able to take a look at this?

Copy link
Owner

@coreylowman coreylowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for tagging

@coreylowman coreylowman merged commit e63940e into coreylowman:main Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants