[Breaking][Waiting to Merge] add support for passing options to nvrtc #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Do you know if there are other compile options we should add? This is a breaking change (we are adding a pub field to a pub struct) so might be a good time to add other options as well, or bundle with other breaking changes |
coreylowman
changed the title
coreylowman
changed the title
brandonros
changed the title
brandonros
changed the title
|
went for a more generic approach. thanks for taking a look, no rush on merging/happy to throw away if needed, glad to see package is maintained. super fun to use, appreciate all of your work on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.