Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select & gather need to check for dim equality with usize dims #448

Closed
coreylowman opened this issue Feb 13, 2023 · 0 comments · Fixed by #454
Closed

select & gather need to check for dim equality with usize dims #448

coreylowman opened this issue Feb 13, 2023 · 0 comments · Fixed by #454
Labels
bug Something isn't working

Comments

@coreylowman
Copy link
Owner

Related to #445
@coreylowman coreylowman added the bug Something isn't working label Feb 13, 2023
coreylowman added a commit that referenced this issue Feb 15, 2023
@coreylowman
#448 runtime shape checks for select/gather
bbf8d34
@coreylowman coreylowman mentioned this issue Feb 15, 2023
Merged
coreylowman added a commit that referenced this issue Feb 15, 2023
@coreylowman
Add more runtime shape checks (#454)
8b3531e 
* #445 Check broadcast shapes

* #448 runtime shape checks for select/gather

* Making inline always
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more runtime shape checks coreylowman/dfdx
1 participant
@coreylowman