-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect PATH in Linux causes build to implode #781
Comments
Thanks for opening. We are just calling I see a couple options here:
Thoughts? |
IMO fail if requirements are not, but in a way that is easily
understandable. This is better than fancy (which pushes the problem
around). Very few devs use mlocate because they are unaware. When I demo
it, everyone I have ever shown it says “what did you just do?”…
…On Fri, May 12, 2023 at 6:27 AM Corey Lowman ***@***.***> wrote:
Thanks for opening. We are just calling std::process::Command("nvcc") in
our build.rs script, which will depend on nvcc being on path.
I see a couple options here:
1. Simplest is just improve the error message here to something very
explicit like "nvcc executable not found on $PATH".
2. Trying to call something like locate nvcc on supported platforms
and giving the found path to std::process::Command
3. Maybe both of the above
Thoughts?
—
Reply to this email directly, view it on GitHub
<#781 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFYRCN7EYB4E7IYVUC4U23XFY3C3ANCNFSM6AAAAAAX53PDHQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
For now I've just improved the error messages. I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
First off, awesome work!
I had not set the path to nvcc, so ]dfdx imploded during build. You may find it of value to tell the user that nvcc could not be found.
Thank you,
-steve
The text was updated successfully, but these errors were encountered: