Improve examples (add Cuda) #452
Conversation
TimerErTim
force-pushed
the
cuda_examples
branch
3 times, most recently
from
2ff7104
to
ad3d4bb
Compare
examples/01-tensor.rs
Outdated
| use dfdx::{ | ||
| shapes::{Const, HasShape, Rank1, Rank2, Rank3}, | ||
| tensor::{AsArray, Cpu, OnesTensor, SampleTensor, Tensor, TensorFrom, ZerosTensor}, | ||
| }; |
There was a problem hiding this comment.
I originally kept the imports as explicit just so people would get to know where things were in the library.
The intention is to probably just use dfdx::prelude most times, but I still wonder if its helpful to have explicit imports in some of the examples.
Thoughts?
There was a problem hiding this comment.
I actually agree with you on that matter. The reason I used prelude nonetheless is, that it automatically imports the Cuda device if the according feature is enabled. Otherwise the dfdx::tensor::cuda::device::Cuda struct has to imported with a #[cfg(feature = "cuda")] safe guard.
I can change that if desired but I think it would look "ugly":
#[cfg(feature = "cuda")]
use dfdx::tensor::cuda::device::Cuda;
#[cfg(feature = "cuda")]
type Device = Cuda;That could well just be me though.
There was a problem hiding this comment.
Oh yeah great point.
Since we are doing type aliases for the devices we could not include cpu/cuda in use statements, and then do:
#[cfg(feature = "cuda")]
type Device = dfdx::tensor::Cuda;
#[cfg(not(feature = "cuda"))]
type Device = dfdx::tensor::Cpu;Probably not as clean as doing prelude, but I think better than doing conditional use
There was a problem hiding this comment.
Done now :)
TimerErTim
force-pushed
the
cuda_examples
branch
2 times, most recently
from
6287a4e
to
42dab6d
Compare
Added possible cuda device to each example. Fixed some typos. Rearranged code. Added some insightful print statements.
TimerErTim
force-pushed
the
cuda_examples
branch
from
42dab6d
to
24b90b8
Compare
Content
Fixes #446
I added Cuda support to every example.
Furthermore, I improved some examples by printing more information or demonstrating more capabilities.
Testing strategy
I tested my code by running every single example on my machine with and without the
cudafeature.Me kissing your a**
I am very impressed by this library and think you did a wonderful work. Out of all the Deep Learning frameworks in the Rust ecosystem, this one is the most intuitive and ergonomic one and it just feels so great.