Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve allocation caching #709

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Improve allocation caching #709

wants to merge 23 commits into from

Commits on Apr 16, 2023

  1. improve TensorCache api; move buffer conversion logic to CacheStorage

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    935810f View commit details
    Browse the repository at this point in the history

  2. split an assert; run cargo fmt

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    0a2d7d9 View commit details
    Browse the repository at this point in the history

  3. reduce visibility of internals; add safety comments

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    347b24b View commit details
    Browse the repository at this point in the history

  4. create safe wrapper around CacheStorage objects

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    f055ae5 View commit details
    Browse the repository at this point in the history

  5. run cargo fmt

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    1697002 View commit details
    Browse the repository at this point in the history

  6. add check_key method to ensure CacheWrappers are used with valid keys

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    240553c View commit details
    Browse the repository at this point in the history

  7. typo; run cargo fmt

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    101497e View commit details
    Browse the repository at this point in the history

  8. add shrink method

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    ea73294 View commit details
    Browse the repository at this point in the history

  9. document ignore_drops; fix constraint violations

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    9efc215 View commit details
    Browse the repository at this point in the history

  10. fix another constraint violation; fix TensorCache::len

    @nkoppel
    nkoppel committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    e99a2ae View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. add size parameter to enable_cache and add set_cache_size

    @nkoppel
    nkoppel committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    76798c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. remove len argument from TensorCache::insert; add test for cache

    @nkoppel
    nkoppel committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e1f4622 View commit details
    Browse the repository at this point in the history

  2. run cargo fmt

    @nkoppel
    nkoppel committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    7476b80 View commit details
    Browse the repository at this point in the history

  3. fix clippy error

    @nkoppel
    nkoppel committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    80c20e7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into caching

    @nkoppel
    nkoppel committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    ed24740 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. remove debug print statements

    @nkoppel
    nkoppel committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3d443ba View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. improve documentation

    @nkoppel
    nkoppel committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9761e41 View commit details
    Browse the repository at this point in the history

  2. add 'in bytes' to enable_cache documentation

    @nkoppel
    nkoppel committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    aef3be9 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. add CacheSize enum

    @nkoppel
    nkoppel committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    59ed3b1 View commit details
    Browse the repository at this point in the history

  2. run cargo fmt

    @nkoppel
    nkoppel committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    902529e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. further clarify comment; remove align to 16 check

    @nkoppel
    nkoppel committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    a2a565d View commit details
    Browse the repository at this point in the history

  2. add check to minimize RwLock operations in shrink; export CacheSize

    @nkoppel
    nkoppel committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    58518e2 View commit details
    Browse the repository at this point in the history

  3. run cargo fmt

    @nkoppel
    nkoppel committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5a03b08 View commit details
    Browse the repository at this point in the history