-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Adding dilation/groups to Conv2D. Adding dilation to Pool2D #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
changed the title
[WIP] Adding dilation/group parameter to Conv2d
[WIP] [Breaking] Adding dilation/group parameter to Conv2d
May 5, 2023
coreylowman
changed the title
[WIP] [Breaking] Adding dilation/group parameter to Conv2d
[Breaking] Adding dilation/groups to Conv2D. Adding dilation to Pool2D
May 8, 2023
This was referenced May 8, 2023
mattjurenka
pushed a commit
to mattjurenka/dfdx
that referenced
this pull request
May 13, 2023
coreylowman#767) * Forward pass for CPU working with dilation/groups * Adding test generation script * Backward img grad working * Backward filters working * Removing large test case * Adding sketches of cuda/cudnn kernels * Update cudnn code * Temp commit * Update filters transpose logic for cuda * Cuda kernel implementation * batched conv2d tests * Fixing dilation * Cudnn passing tests * cuda tests passing * Reverting numpy tests * Removing old conv2d implementation * Pool2D rewrite * Updates for pool2d cuda * Adding dilated pool2d test * Adding dilation & groups to nn layer * Adding conv2d dilation & group tests * Fixing tests & warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #693
Resolves #589
Breaking API changes
New features
Tests ran
cargo +nightly test --tests
cargo +nightly test --tests -F test-f64
cargo +nightly test --tests -F test-f16
cargo +nightly test --tests -F cuda
cargo +nightly test --tests -F cuda,test-f64
cargo +nightly test --tests -F cuda,test-f16
cargo +nightly test --tests -F cudnn
cargo +nightly test --tests -F cudnn,test-f64
cargo +nightly test --tests -F cudnn,test-f16