Improve concision #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use match ergonomics to simplify the pattern matching. When matching a
reference value with a non-reference pattern, the default binding mode
is automatically set to `ref`. In this case, by removing the `&` on the
tuples and the `ref` keywords on their fields, the variables
`{a,b}_{item,count}` are bound as references.
Replace the `match` expression with `Ordering::then_with()`, which does
the same thing more succinctly.
We can directly loop over containers of type `I: IntoIter` without having to call `IntoIter::into_iter()` explicitly; that is part of the syntactic sugar of `for`-loops.
coriolinus
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some suggestions for making the code a little more concise in a few places.
Ordering::then_with()inCounter::most_common_tiebreaker()..into_iterator()inforloops