Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bitwise and and or assignments #28

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Implement bitwise and and or assignments #28

merged 1 commit into from
Sep 22, 2022

Conversation

mjpieters
Copy link
Contributor

@mjpieters mjpieters commented Sep 22, 2022 •
edited

I also added a documentation section for the bitwise operations.

@mjpieters
Implement bitwise and and or assignments
e17f8a9 
Add a documentation section for the bitwise operations.
coriolinus
coriolinus approved these changes Sep 22, 2022
View reviewed changes
Copy link
Owner

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@coriolinus coriolinus merged commit 2481e21 into coriolinus:master Sep 22, 2022
@mjpieters mjpieters deleted the bitand_or_assign branch September 22, 2022 21:37
@mjpieters
Copy link
Contributor Author

mjpieters commented Sep 22, 2022 •
edited

There's an oopsie in it though; 'intersection' is misspelled in a header 🤦

I'll see about that tomorrow perhaps.

@coriolinus
Copy link
Owner

coriolinus commented Sep 22, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjpieters @coriolinus