Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ivy build update angular #571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

acb122
Copy link

@acb122 acb122 commented Apr 25, 2020

ngcc compiler was failing this fixes it by exporting the correct files which are being exported in the ngmodule. I have tested it locally and fixes the error i was seeing using ivy.

@trakhimenok
Copy link

trakhimenok commented May 13, 2020

How this fixes Ivy build if it's simply disables Ivy mode?

@acb122
Copy link
Author

acb122 commented May 13, 2020

The library is placed into npm not rendered in IVY mode making it usable for everyone. If you are then running IVY angular has a compile step that runs when you npm install on the postinstall stage it compiles it to ivy runtime code. This fixes the code so it compiles to ivy runtime code.

@acb122
Copy link
Author

acb122 commented May 22, 2020

@cormacrelf Please could you merge this in? would love to use the library on the project i am working on.

@lincolnthree
Copy link

lincolnthree commented Jul 3, 2020

This still appears to be an issue with Angular 10, despite their compiler fallback optimizations. Just FYI.

@acb122
Copy link
Author

acb122 commented Jul 6, 2020

Are you running my branch as its still not merged in, I am using my branch and it works fine with angular 10 Ivy.

@cormacrelf Please review so we can easily use your library.

@lincolnthree
Copy link

Interesting @acb122 - I tried your master branch (which was referenced in the PR) but was unable to get it to work --- it might actually work, but I am also using the multi-backend module so maybe this was just an additional issue.

I ended up making a whole bunch of local modifications and finally tracked the issue down to improper initialization of the default multi backend which was failing to create the HTML5ToTouch backend. This is what I ended up with after upgrading dnd-multi-backend@latest:

    SkyhookDndModule.forRoot({ backend: createDefaultMultiBackend(), options: HTML5ToTouch }),
export function createDefaultMultiBackend(): BackendFactory {
    return (manager, ctx) => {
      return MultiBackend(manager, ctx, HTML5ToTouch) as any;
    };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants