New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ivy build update angular #571
base: master
Are you sure you want to change the base?
Conversation
How this fixes Ivy build if it's simply disables Ivy mode? |
The library is placed into npm not rendered in IVY mode making it usable for everyone. If you are then running IVY angular has a compile step that runs when you npm install on the postinstall stage it compiles it to ivy runtime code. This fixes the code so it compiles to ivy runtime code. |
@cormacrelf Please could you merge this in? would love to use the library on the project i am working on. |
This still appears to be an issue with Angular 10, despite their compiler fallback optimizations. Just FYI. |
Are you running my branch as its still not merged in, I am using my branch and it works fine with angular 10 Ivy. @cormacrelf Please review so we can easily use your library. |
Interesting @acb122 - I tried your master branch (which was referenced in the PR) but was unable to get it to work --- it might actually work, but I am also using the multi-backend module so maybe this was just an additional issue. I ended up making a whole bunch of local modifications and finally tracked the issue down to improper initialization of the default multi backend which was failing to create the HTML5ToTouch backend. This is what I ended up with after upgrading
|
ngcc compiler was failing this fixes it by exporting the correct files which are being exported in the ngmodule. I have tested it locally and fixes the error i was seeing using ivy.