Use OS specific tmp path instead of hardcoded '/tmp' in tests. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlasiusVonSzerencsi
force-pushed
the
master
branch
from
3169a39
to
9c017f9
Compare
|
Sorry for taking so long to look at your pull requests. Doing it now. Making the tests work on systems which have their tmp dirs elsewhere makes a lot of sense and your implementation is nice and clean. I'll merge it. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests could not be run on Mac OS X, because (for whatever reason) it does not use the /tmp directory as the temp directory root.