Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PodMetrics as excluded resource by default #51

Merged

Conversation

Aracki
Copy link
Contributor

@Aracki Aracki commented Feb 3, 2020

r.APIResource.Kind is the only way to distinct Pod & PodMetrics because they have the same .Name.

@codecov-io
Copy link

codecov-io commented Feb 3, 2020

Codecov Report

Merging #51 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   41.96%   42.11%   +0.14%     
==========================================
  Files           9        9              
  Lines         386      387       +1     
==========================================
+ Hits          162      163       +1     
  Misses        202      202              
  Partials       22       22
Impacted Files Coverage Δ
internal/client/client.go 23.91% <100%> (+0.55%) ⬆️
cmd/root.go 68.88% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 185b51c...3f260d6. Read the comment docs.

@corneliusweig
Copy link
Owner

Hi @Aracki,

thanks for working on this! It makes sense to also filter by resource kind, so this is really nice. I just need to ask you to signoff your commits with git commit --amend --signoff.

Signed-off-by: Aracki <aracki.ivan@gmail.com>
@Aracki Aracki force-pushed the exclude-podsmetrics-by-default branch from 38e29d4 to 3f260d6 Compare February 5, 2020 07:23
@Aracki
Copy link
Contributor Author

Aracki commented Feb 5, 2020

@corneliusweig Did that 👍

@corneliusweig corneliusweig merged commit e1ee036 into corneliusweig:master Feb 5, 2020
@corneliusweig
Copy link
Owner

Thanks again!

@Aracki Aracki deleted the exclude-podsmetrics-by-default branch February 5, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants