Retiring deprecated versions ofpsd_safe_cholesky
, NotPSDError
, and assert_allclose
#2130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retires
psd_safe_cholesky
in favor of the LinearOperator versionNotPSDError
in favor of the LinearOperator versiontorch.testing.assert_allclose
in favor oftorch.testing.assert_close
.assert_close
has been in torch since 1.9 and since GPyTorch requires torch>=1.11, this should not cause any bad behavior, see here for details.