Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix custom dtype_value_context setting #2132

Merged
merged 1 commit into from
Sep 9, 2022
Merged

fix custom dtype_value_context setting #2132

merged 1 commit into from
Sep 9, 2022

Conversation

sdaulton
Copy link
Collaborator

@sdaulton sdaulton commented Sep 9, 2022

Previously, setting custom values in dtype_value_context was broken because dtype_value_context.value requires a dtype argument and no dtype argument was provided in the calls in dtype_value_context.__init__.

@sdaulton sdaulton added the bug label Sep 9, 2022
Balandat
Balandat approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow this seems like a pretty bad bug. Thanks for adding the tests!

@Balandat Balandat merged commit d8d5151 into cornellius-gp:master Sep 9, 2022
@sdaulton sdaulton deleted the min_noise branch September 9, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balandat Balandat Balandat approved these changes

@gpleiss gpleiss Awaiting requested review from gpleiss

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdaulton @Balandat @docusaurus-bot