-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HalfNormal prior distribution for non-negative variables. #2147
Conversation
Halfnormal distribution could be useful for variables that are constrained to be non-negative.
Awesome, thanks! |
Resolving comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you please also add some unit tests, similar to https://github.com/cornellius-gp/gpytorch/blob/master/test/priors/test_normal_prior.py ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally lg let's fix the test and flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Halfnormal distribution could be useful for variables that are constrained to be non-negative.