Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving _sq_dist when x1_eq_x2 #2204

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Improving _sq_dist when x1_eq_x2 #2204

merged 1 commit into from
Nov 29, 2022

Conversation

SebastianAment
Copy link
Contributor

This commit moves the adjustment of x2 into the else branch if x1_eq_x2 == True, since it is not necessary in this case.

@SebastianAment
Copy link
Contributor Author

The doc build failure is caused by ipython3 not being found. Seems to be an unrelated issue.

Balandat
Balandat approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Screen Shot 2022-11-28 at 7 03 29 PM

@Balandat Balandat merged commit 80e61f7 into cornellius-gp:master Nov 29, 2022
@SebastianAment SebastianAment deleted the distance branch November 29, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balandat Balandat Balandat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SebastianAment @Balandat