gpytorch.settings.variational_cholesky_jitter can be set dynamically. #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balandat
approved these changes
Feb 5, 2023
Previously, this context manager was only used when VariationalStrategy modules were initialized. With this change, gpytorch.settings.variational_cholesky_jitter will dynamically change the jitter value (for variational models already in use), unless the user specifies a `jitter_val` in the VariationalStrategy constructor. In addition, this PR adds type hintsd to a majority of the VariationalStrategy modules. [Fixes #2244]
gpleiss
force-pushed
the
dynamic_variational_jitter
branch
from
497830b
to
854df95
Compare
gpleiss
force-pushed
the
dynamic_variational_jitter
branch
from
854df95
to
be2ce67
Compare
gpleiss
force-pushed
the
dynamic_variational_jitter
branch
from
be2ce67
to
a10155c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this context manager was only used when VariationalStrategy modules were initialized. With this change,
gpytorch.settings.variational_cholesky_jitter will dynamically change the jitter value (for variational models already in use), unless the user specifies a
jitter_valin the VariationalStrategy constructor.In addition, this PR adds type hintsd to a majority of the VariationalStrategy modules.
[Fixes #2244]