fix(rectangle): ROI and Rotation Tool Interaction (RectangleROITool) #1217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This fix addresses the issue #713 where an error occurred in the interaction between the RectangleROITool and Rotation tools
Changes & Results
drawRectByCoordinates
function by passingcanvasCoordinates
and executing precise calculations for rectangle position after applying rotation transform angle.drawRect
function was kept for backward compatibility,Before:
#713 videos
Testing
After:
https://github.com/cornerstonejs/cornerstone3D/assets/2040590/905a7442-f3b4-4ea4-bd7e-386b67f4ff33
Testing:
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment