Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colormap): Resolve bugs related to colormap reset and colorbar #1225

Merged
merged 16 commits into from
Apr 29, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 23, 2024

Context

There were a lot of bugs regarding colormap reset and colorbar

previous

https://share.cleanshot.com/TLkd0GGr

After

https://share.cleanshot.com/p3lmCbhd

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit a2d3056
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/662fb361c64088000803e282
😎 Deploy Preview https://deploy-preview-1225--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title wadouri/fix fix(colormap): Resolve bugs related to colormap reset and colorbar Apr 23, 2024
@sedghi sedghi requested a review from IbrahimCSAE April 23, 2024 20:31
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sedghi sedghi merged commit aaac143 into main Apr 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants