add types for wasm codec modules #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedghi
approved these changes
Feb 23, 2023
There was a problem hiding this comment.
I guess we need to put these at the codecs repo https://github.com/cornerstonejs/codecs, but we can use them here for now
sedghi
approved these changes
Feb 23, 2023
sedghi
changed the title
sedghi
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Improve WARORS types as per PR comments * [dicom-image-loader] add types for wasm codec modules * [dicom-image-loader] relocate WASM types --------- Co-authored-by: James Manners <james@binary.com.au>
sedghi
added a commit
that referenced
this pull request
Mar 3, 2023
* initial effort * internal options * wip * add wadors metadata types * wip * finish wadors * wadouri metadata * image loader wip * finish image loader * shared * added all types * updated package json * rename * rename * finish rename * fix missing types * rename wado * fix build * update yarn lock * Improve WARORS types as per PR comments (#449) Co-authored-by: James Manners <james@binary.com.au> * add types for wasm codec modules (#450) * Improve WARORS types as per PR comments * [dicom-image-loader] add types for wasm codec modules * [dicom-image-loader] relocate WASM types --------- Co-authored-by: James Manners <james@binary.com.au> * apply review comments - working dynamic import * rename dicom image loader to cornerstone image loader * replace cswado with csdicom loader * bring back cs wado for now --------- Co-authored-by: James Manners <james@manners.net.au> Co-authored-by: James Manners <james@binary.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.