fix(sab): check for sab before using it #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
CC @Ouwen I think this is what you were talking in the office hours |
jbocce
suggested changes
Jun 9, 2023
| // we need to identify if the target buffer is a SharedArrayBuffer | ||
| // since inside the webworker we don't have access to the window | ||
| // to say if it is a SharedArrayBuffer or not with instanceof | ||
| options.isSharedArrayBuffer = |
There was a problem hiding this comment.
this is still not correct. it should be...
options.isSharedArrayBuffer =
options.targetBuffer.arrayBuffer &&
options.targetBuffer.arrayBuffer instanceof SharedArrayBuffer;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAB requires a secure context, and stack viewport can work without it (although MPR still needs a secure context https and CORS headers to work), but this will solve making the viewer actually work in the stack viewport at least.
https://community.ohif.org/t/dicom-images-infinite-loading/831/2?u=jbocce
Changes & Results
Check for SAB before using it
Testing
Run viewer against an unsecure context (localhost is secure by design), run it against an ip
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment