[DONT MERGE] feat(webworker): Reworking Web Worker API and new WebWorkerManager #880
+7,562
−7,385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RequestPoolManager
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
configuration.
external modules
sedghi
changed the title
package.json and karma.conf.js.
RequestPoolManager
lscoder
reviewed
Nov 14, 2023
| } | ||
|
|
||
| this.workerTypes[workerName].instances.forEach((workerInstance) => { | ||
| workerInstance[Comlink.releaseProxy](); |
There was a problem hiding this comment.
What happens if the worker is running something? Does Comlink waits for it to complete the task before destroying it?
There was a problem hiding this comment.
Maybe we should not be worried about that since all workers may not be destroyed at any time, right?
There was a problem hiding this comment.
I don't think that is a problem
sedghi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely we won't merge this into
mainthe diff is just easier to see to the mainWe will merge this one first , and in cornerstone3D 2.0 we will move all decoders to the new manager as well to have central place to manage all.
Context
This PR reworks the web worker API and proposes a new set of methods to work with workers to make developers life so much easier to be able to run a function of the main thread
Changes & Results
Testing
You should be able to follow the added documentation to easily write, register and execute a function in a way that makes a lot of sense.
Checklist
PR
semantic-release format and guidelines.
Code
[] My code has been well-documented (function documentation, inline comments,
etc.)
[] I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment