Rejects loading of images without pixel data #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swederik and @dannyrb, my original plan was of patching version 1.0.5, because I hadn't updated cornerstone et al to v2. However, I have successfully upgraded it here. Hence, I don't need this fix applied to v1 anymore. If I can help in any way (maybe creating an issue to better describe/reproduce the problem), please let me know. |
|
@fegemo Could you rebase this? Thanks |
fegemo
force-pushed
the
fix-no-pixel-data-images
branch
from
b886e37
to
81942bf
Compare
|
@swederik just rebased this on top of master! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swederik this fixes an exception that happens when no pixel data is associated with an image. I committed right after the commit tagged with 1.0.5. Hence, that's why there may be conflicts.
If this is not the way to go, just let me know how I should proceed to get this merged.