getPixelDataFromFragments - Bad Uint8Array initialization

[g-squared]

I found a strange behavior in the case of a single fragment and a new Uint8Array is crated as a view of the dicom object byteStream: the new array is misaligned from the source buffer.
In my case the new array is two bytes ahead: fragments[0].dataOffset is 2056, the new array starts at byte 2054 of the byteStream. Length is correct.
I found this behavior using Safari on Mac OS X, Chrome and Firefox on Ubuntu Linux x64, Chrome on Windows 7 x64. Could be a dword alignment? but 2056 is at dword boundaries!
The work around I applied is to comment the if( fragments.lenght === 1) condition.

[chafey]

Can you provide a sample dataset and fix via PR? Thanks

[g-squared]

Attached a sample dataset.
trasversal.3.dcm.zip

I will submit the PR next week.
Thank to you.

[chafey]

I think I may have fixed this in 1.4.3, can you please test?

[g-squared]

I apologize for not posting the additional info you requested but my
workload did not allow me.
Unfortunately at the moment I had to pause my projects with cornerstone and
your progress in developing it was so big that I hardly recognize the same
library! I'm stuck with a very old version that I customized for special
purposes so testing a new release is almost impossible to me.

Sorry for not being more helpful

On Fri, May 20, 2016 at 3:02 PM, Chris Hafey notifications@github.com
wrote:

I think I may have fixed this in 1.4.3, can you please test?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#38 (comment)

[chafey]

Closing