Allow Component to handle all event listeners without binding external #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@todd-dembrey, if you update this on latest changes, I am more than happy to merge. Usage for binding to "elements" or "cornerstone.events" should be clearer in latest changes. Some events are element specific, others are only emitted at the library level. We could probably simplify this so that all events could be listened to at |
todd-dembrey
force-pushed
the
bugfix/binding-of-event-listeners
branch
4 times, most recently
from
8e4f71b
to
aa39875
Compare
Wrap all events in a single handler which will delegate out the events to the provided functions. This means that if the external function changes we do not need to rebind the function, fixing issues with functional react components.
todd-dembrey
force-pushed
the
bugfix/binding-of-event-listeners
branch
from
aa39875
to
8faa971
Compare
|
🎉 This PR is included in version 2.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap all events in a single handler which will delegate out the events to the
provided functions. This means that if the external function changes we do not
need to rebind the function, fixing issues with functional react components.
Fixes #49 and should be an improvement on #48
I'm not sure about the difference of binding to element and cornerstone so i bound to both - might be nice to refine this. Equally i no longer check the element that fired the event in
_handleExternalEventListenersso would appreciate some feedback there.