Feat/Fix: Add Prospects to Subcourse & Prevent Invalid Email Changes #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
realmayus
commented
Jun 6, 2024
realmayus
commented
- Add prospect list in course overview to allow instructors to add prospects (frontend part of Store prospect chats in subcourse entity backend#1093)
- prevent user from changing email to itself (violates uniqueness constraint in DB)
…pects, prevent user from changing email to itself (violates uniqueness constraint in DB)
| const handleAddPupil = useCallback( | ||
| async (pupilId: number) => { | ||
| try { | ||
| await addProspect({ variables: { subcourseId: subcourseId, pupilId: pupilId } }); |
There was a problem hiding this comment.
while this is loading I could click the button again
| data?.me?.email.toLowerCase().trim() === newEmail?.toLowerCase().trim() | ||
| ? t('reasonsDisabled.didNotChangeEmail') | ||
| : t('reasonsDisabled.invalidEMail') | ||
| } | ||
| width={buttonWidth} |
There was a problem hiding this comment.
How does this "Prevent invalid email changes" - It just swaps the disabled message in that case?
There was a problem hiding this comment.
And if it hits the uniqueness constraint we probably also miss validation on backend side.
|
(would prefer one change per PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.