Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Enhancement to notification of risk change #1066

Closed
3 tasks done
kbobrowski opened this issue Aug 23, 2020 · 5 comments · Fixed by #1067
Closed
3 tasks done

Enhancement to notification of risk change #1066

kbobrowski opened this issue Aug 23, 2020 · 5 comments · Fixed by #1067
Labels
enhancement Improvement of an existing feature

Comments

@kbobrowski
Copy link
Contributor

Avoid duplicates

  • This enhancement request has not already been raised before
  • Enhancement request is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
  • If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

Currently the notification does not have any title, and it cannot be expanded to view the full text

Screenshot_20200823-104942

Suggested Enhancement

It could be displayed similar to notification which can be generated by ENF when querying ExposureInformation, which has a title and full text visible. Additionally it could include a message about the risk directly in the notification. Would be nice to also have the icon in the same color as original CWA logo, not grey, to make it a bit more prominent.

Expected Benefits

Improved UX, better chance that notification is not dismissed accidentally.

@kbobrowski kbobrowski added the enhancement Improvement of an existing feature label Aug 23, 2020
@thomasaugsten
Copy link
Member

The data privacy has strictly standards to not show any push notifications where other people can see the app is installed or the person received a test result. If it's really necessary the notification must not show sensible information or any hints that the person did a test.

@kbobrowski
Copy link
Contributor Author

kbobrowski commented Aug 23, 2020

@thomasaugsten thanks for the information, then I'll limit this enhancement idea just to a suggestion to add any sort of title, maybe same colorful logo as in the app, and allow the notification to be expanded to display the full text (by "dragging down" on it), right now user can just read:

You have new messages from your Corona

instead of:

You have new messages from your Corona-Warn-App.

@kbobrowski
Copy link
Contributor Author

kbobrowski commented Aug 23, 2020

What I have in mind is something like this (not sure why the logo is grayed out):

Current Enhancement
Screenshot_20200823-104942 Screenshot_20200823-124639

@thomasaugsten
Copy link
Member

Looks good feel free to open a PR for this enhancement

@kbobrowski
Copy link
Contributor Author

@thomasaugsten I've opened PR only for expandable text as changing the title would require changes in strings for all the languages, but the functionality to add the title is in the code already, it's just defined as "" (same line as the line affected by PR)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants