Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Contacts and places are sorted case insensitive #2012

Closed
3 tasks done
Bananeweizen opened this issue Dec 30, 2020 · 4 comments · Fixed by #2017
Closed
3 tasks done

Contacts and places are sorted case insensitive #2012

Bananeweizen opened this issue Dec 30, 2020 · 4 comments · Fixed by #2017
Assignees
Labels
bug Something isn't working contact-journal contact-diary Fix 1.11 Fix is planned for 1.11 mirrored-to-jira This item is also tracked internally in JIRA

Comments

@Bananeweizen
Copy link
Contributor

Bananeweizen commented Dec 30, 2020

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for Android only (cannot check on Apple hardware)
  • Bug is not already reported in another issue

Describe the bug

Contacts and places are sorted case insensitive. That makes it harder to find a contact again, if names are (accidentally) created with mixed lowercase and uppercase characters. UI elements sorted alphabetically should generally be case insensitive in all applications.

Steps to reproduce the issue

  1. Create contact "B".
  2. Create contact "A1".
  3. Create contact "a2".

Expected behaviour

Contacts should be sorted A1, a2, B (case insensitive). Contacts are sorted A1, B, a2 (case sensitive).
The same issue exists for places.

Possible Fix

If that is a Java collection being sorted, a second argument String.CASE_INSENSITIVE for the Collections.sort() call would be an appropriate fix.


Internal Tracking ID: EXPOSUREAPP-4488

@Bananeweizen Bananeweizen added the bug Something isn't working label Dec 30, 2020
@cwa-bot cwa-bot bot added this to ToDo in [CM] cwa-app-android Dec 30, 2020
@dsarkar dsarkar added the in review Moderators are investigating how to best proceed with the issue label Dec 30, 2020
@dsarkar dsarkar moved this from ToDo to In Progress in [CM] cwa-app-android Dec 30, 2020
PhilippNowak96 added a commit to PhilippNowak96/cwa-app-android that referenced this issue Dec 30, 2020
@PhilippNowak96
Copy link
Contributor

I created a PR (#2017) to fix this issue for persons, locations and the overview itself.

@cwa-bot cwa-bot bot moved this from In Progress to ToDo in [CM] cwa-app-android Dec 30, 2020
@dsarkar dsarkar added mirrored-to-jira This item is also tracked internally in JIRA and removed in review Moderators are investigating how to best proceed with the issue labels Dec 31, 2020
@cwa-bot cwa-bot bot moved this from ToDo to Mirrored to Jira in [CM] cwa-app-android Dec 31, 2020
@dsarkar
Copy link
Member

dsarkar commented Dec 31, 2020

Dear @Bananeweizen, @PhilippNowak96, and community

Thank you for your contributions. We have created a ticket for the bug in the internal Jira system. Any further developments will be notified here in this Github issue.

Best wishes,
DS


Corona-Warn-App Open Source Team
Internal Tracking ID: EXPOSUREAPP-4488

@dsarkar
Copy link
Member

dsarkar commented Dec 31, 2020

Tested: not an issue in iOS 14.3 / iPhone 6s / CWA 1.10.1

image

@MikeMcC399
Copy link
Contributor

"Fix sorting of persons and places to be case insensitive for names (EXPOSUREAPP-4488)(closes #2012)" #2017 is included in v1.11.0-RC1.

@cwa-bot cwa-bot bot moved this from Mirrored to Jira to ToDo in [CM] cwa-app-android Jan 16, 2021
@heinezen heinezen moved this from ToDo to Mirrored to Jira in [CM] cwa-app-android Jan 17, 2021
@d4rken d4rken closed this as completed in 957efe2 Jan 29, 2021
@cwa-bot cwa-bot bot moved this from Mirrored to Jira to Done in [CM] cwa-app-android Jan 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working contact-journal contact-diary Fix 1.11 Fix is planned for 1.11 mirrored-to-jira This item is also tracked internally in JIRA
5 participants