Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Statistics snaps to second card after swiping right #2259

Closed
3 tasks done
MikeMcC399 opened this issue Feb 1, 2021 · 6 comments
Closed
3 tasks done

Statistics snaps to second card after swiping right #2259

MikeMcC399 opened this issue Feb 1, 2021 · 6 comments
Labels
bug Something isn't working Fix 1.13 Fix is planned for 1.13 mirrored-to-jira This item is also tracked internally in JIRA

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Feb 1, 2021

Avoid duplicates

  • Bug is not mentioned in the FAQ
  • Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
  • Bug is not already reported in another issue

Technical details

  • Device name: Samsung Galaxy Tablet A SM-T510
    10.1inch 1200 x 1920 pixels, 16:10 ratio (~224 ppi density)
  • Android version: 10
  • App version: 1.11.0 1.12.0

Describe the bug

After swiping the statistics left, then swiping right it is not possible to leave the card "Confirmed New Infections" showing completely.

The same issue appears when swiping completely left. The card "7-Day R Value" is not completely displayed.

Steps to reproduce the issue

  1. Scroll down to the statistics cards starting with "Confirmed New Infections" which looks similar to the following screenshot
    Starting statistics
  2. Now swipe to the left and back to the right fully. The first card on the left is no longer completely displayed.
    Snapped statistics
  3. To restore the view, tap on any of the ℹ️ icon and then tap the back button.

Expected behaviour

If the cards are swiped fully to the right, then they should stay there and not be snapped slightly to the left again and vice versa.

Possible Fix

PagerSnapHelper() is responsible.

Additional context

I found only my tablet (16:10 ratio), but not my phone (19.5:9 ratio) is affected. I don't know exactly the conditions where it starts to become problematic unfortunately, but it looks like it may only affect relatively wider devices.


Internal Tracking ID: EXPOSUREAPP-4945

@MikeMcC399 MikeMcC399 added the bug Something isn't working label Feb 1, 2021
@cwa-bot cwa-bot bot added this to ToDo in [CM] cwa-app-android Feb 1, 2021
@PhilippNowak96
Copy link
Contributor

It's reproducible with a Nexus 10 2560x1600 xhdpi emulator (using Android 10 image) for me. Had no look with a 1200x1920 emulator. I think I will have a look into this :)

PhilippNowak96 added a commit to PhilippNowak96/cwa-app-android that referenced this issue Feb 1, 2021
@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Feb 2, 2021
@cwa-bot cwa-bot bot moved this from ToDo to Mirrored to Jira in [CM] cwa-app-android Feb 2, 2021
@dsarkar
Copy link
Member

dsarkar commented Feb 2, 2021

Internal Tracking ID: EXPOSUREAPP-4945

@dsarkar
Copy link
Member

dsarkar commented Feb 2, 2021

@MikeMcC399, @PhilippNowak96 Thanks. Internally tracked, see above.

PhilippNowak96 added a commit to PhilippNowak96/cwa-app-android that referenced this issue Feb 4, 2021
PhilippNowak96 added a commit to PhilippNowak96/cwa-app-android that referenced this issue Feb 8, 2021
PhilippNowak96 added a commit to PhilippNowak96/cwa-app-android that referenced this issue Feb 8, 2021
@MikeMcC399
Copy link
Contributor Author

PR #2260 (EXPOSUREAPP-4945) is now included in the 1.13.0 Milestone.

@cwa-bot cwa-bot bot moved this from Mirrored to Jira to ToDo in [CM] cwa-app-android Feb 8, 2021
@dsarkar dsarkar added the Fix 1.13 Fix is planned for 1.13 label Feb 8, 2021
@dsarkar dsarkar moved this from ToDo to Mirrored to Jira in [CM] cwa-app-android Feb 8, 2021
@d4rken d4rken closed this as completed in 5cfb5c7 Mar 5, 2021
@cwa-bot cwa-bot bot moved this from Mirrored to Jira to Done in [CM] cwa-app-android Mar 5, 2021
@MikeMcC399
Copy link
Contributor Author

The fix was released with CWA Android 1.13.2 and I confirmed that it works on the device that I originally reported it on (Samsung Galaxy Tablet A SM-T510).

@cwa-bot cwa-bot bot moved this from Done to ToDo in [CM] cwa-app-android Mar 6, 2021
@dsarkar
Copy link
Member

dsarkar commented Mar 7, 2021

@MikeMcC399 thanks for reporting and feedback.

@heinezen heinezen moved this from ToDo to Done in [CM] cwa-app-android Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Fix 1.13 Fix is planned for 1.13 mirrored-to-jira This item is also tracked internally in JIRA
Development

No branches or pull requests

3 participants