Scan errors for non-CWA QR codes pop up on frontend

[koehntopp]

From

https://twitter.com/sand2drn/status/1385197350025564163

Exception handling should be improved, meaningful error message shown.

---

https://github.com/corona-warn-app/cwa-app-android/releases/tag/v2.0.4
Internal Tracking ID: EXPOSUREAPP-6658

[MikeMcC399]

If a user inadvertently tries to scan in a QR code from a PCR test instead of from a check in, then the same error occurs.

Steps to reproduce

1. Tap Check In
2. Tap "SCAN QR CODE" and then point to QR code from bottom half of example form 10C form

Expected result

In this special case, a dedicated error message should point users to the correct way of scanning in a PCR test QR code.

For other QR codes, which are not in the format for checking in, then a user-friendly error message should be output.

[koehntopp]

[sand2dorn]

I tried it with several QR codes from Google Image Search. Same result.

Oh, you're fast… 😺

[dsarkar]

@koehntopp @MikeMcC399 Thank you very much for the reports. Internal Tracking ID: EXPOSUREAPP-6658

---

Corona-Warn-App Open Source Team

[Ein-Tim]

@MikeMcC399

I suggest that you open a new wishlist item regarding #2909 (comment).

[MikeMcC399]

@dsarkar
What do you think about the suggestion from @Ein-Tim ?

I suggest that you open a new wishlist item regarding #2909 (comment).

Is wrongly scanning a PCR Test QR code using the Check-in QR code scanner already covered by Internal Tracking ID: EXPOSUREAPP-6658 or does it need a separate wishlist item?

[MikeMcC399]

@Ein-Tim

What happens on iOS if you try to scan in the sample PCR test QC code using check-in?

Do you get a user-friendly error message?

[Ein-Tim]

@MikeMcC399

iOS shows this message, which is quite good I think:

[dsarkar]

@MikeMcC399 @Ein-Tim

Is wrongly scanning a PCR Test QR code using the Check-in QR code scanner already covered by Internal Tracking ID: EXPOSUREAPP-6658 or does it need a separate wishlist item?

That would be a new wishlist item.

The alignment of iOS and Android error messages is dealt with in this ticket.

[dsarkar]

FYI PR #2919

[MikeMcC399]

@dsarkar

In https://github.com/corona-warn-app/cwa-app-android/releases/tag/v2.0.4-RC0 which includes PR "Human friendly QR Dialog Message 9002 (EXPOSUREAPP-6658)" #2919

the issue is fixed in the code, however the message is not translated yet. If the locale is set to English (United Kingdom) then the UI is shown in German. The default strings file includes only German, and the specific English strings file is missing the entries.

I assume this is known, however I just wanted to mention it.

cwa-app-android/Corona-Warn-App/src/main/res/values/strings.xml

Lines 2004 to 2011 in 59015a7

	<!-- XHED: Trace location check-ins invalid qr code dialog title -->
	<string name="trace_location_attendee_invalid_qr_code_dialog_title">QR-Code nicht gültig</string>
	<!-- YTXT: Trace location check-ins invalid qr code dialog message -->
	<string name="trace_location_attendee_invalid_qr_code_dialog_message">Der gescannte QR-Code ist nicht gültig.\nBitte scannen Sie einen gültigen QR-Code.\n\n(%1$s)</string>
	<!-- XBUT: Trace location check-ins invalid qr code dialog positive button -->
	<string name="trace_location_attendee_invalid_qr_code_dialog_positive_button">Ok</string>
	<!-- XBUT: Trace location check-ins invalid qr code dialog negative button -->
	<string name="trace_location_attendee_invalid_qr_code_dialog_negative_button">Abbrechen</string>

[dsarkar]

@MikeMcC399 Many thanks. Forwarded into internal ticket.

[MikeMcC399]

The missing English language strings have been delivered and incorporated into https://github.com/corona-warn-app/cwa-app-android/releases/tag/v2.0.4-RC1.

Scanning the PCR test example QR code, with the device locale set to English (United Kingdom), results in a human-readable error message in English.

It looks like the fix is now good to go!

[dsarkar]

FYI https://github.com/corona-warn-app/cwa-app-android/releases/tag/v2.0.4

[MikeMcC399]

@dsarkar

Google Play Store has already delivered the bug-fix release v2.0.4 to me and I was able to verify that the fix correctly displays a user-friendly error message when scanning the PCR test QR code.

From my point of view this issue can be closed. Perhaps @koehntopp can confirm when he is able to update and check?

[dsarkar]

@MikeMcC399 Thanks for confirming the fix.

[heinezen]

Dear community,

This issue has been fixed in CWA 2.0.4. We will close this issue now.

---

Corona-Warn-App Open Source Team