This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Solve unreliable tests #1266
Merged
Solve unreliable tests #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random could be randomly 0 which would fail the test.
Use these build variants for specific tests.
Until refactored, it's okay to recalculate this.
8 tasks
Add matching binary, signature and pubkey from pod.
|
Kudos, SonarCloud Quality Gate passed!
|
mertsafter
approved these changes
Oct 1, 2020
| @@ -54,18 +66,21 @@ class VerificationKeysTest { | |||
| } | |||
|
|
|||
| companion object { | |||
| private const val PUB_KEY = | |||
There was a problem hiding this comment.
What do you think about moving the companion object to the beginning of the class? I personally like to see all consts/companions at first of the class so I know what consts are used in the code
There was a problem hiding this comment.
I like the opposite, I think the constants distract from the global variables and constructor arguments.
Our goal is to follow the Kotlin code conventions which recommend companion objects at the end:
https://kotlinlang.org/docs/reference/coding-conventions.html
SamuraiKek
approved these changes
Oct 1, 2020
chris-cwa
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Few tests are unreliable.
Related to singletons and build flavors.
How to test