Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Country list on Risiko-Ermittlung AFTER WLAN ON (EXPOSUREAPP-3152) #1372

Merged
merged 10 commits into from Oct 12, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

Description

Small fix for issue 3152 where the country list would not appear after switching Wifi off and then back on again because the network callbacks defined were not working properly.

Adjusted the network connectivity check and is now working as expected.

Test

  • Install the App, switch of WLAN,
  • Do the onboarding > Contry list missing
  • on the Homescreen choose Exposure Logging > Country List - Country List Missing check device settings
  • go to homescreen
  • go to smartphone settings, turn WLAN on
  • go back to the app, check WLAN via "Häufige Fragen" > Browser starts, external website appears
  • go back to the app, choose Exposure Logging > Country List - Country List Missing check device settings ---> List should now appear where previously it did not.

@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team October 9, 2020 15:42
@harambasicluka harambasicluka added this to the 1.5.0 milestone Oct 12, 2020
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Oct 12, 2020
ralfgehrer
ralfgehrer previously approved these changes Oct 12, 2020
@BMItr
Copy link
Contributor

BMItr commented Oct 12, 2020

@Oliver-Zimmerman Hi Oliver, I just did a quick look. I think without somekind of callback or observer this would indicate another problem: wifi usually needs some seconds to establish a connection. If you return to the App or Onboarding before having a connection, it could result in country list not showing...

@Oliver-Zimmerman
Copy link
Contributor Author

@BMItter interesting, I didn't consider this. I will test it again to see if this issue occurs and adjust based on my findings. Did you test to see if this issue was occurring? I imagine it would only appear if you enable WLAN right before going to the country list screen.

@BMItr
Copy link
Contributor

BMItr commented Oct 12, 2020

Yes, I did a quick test.. maybe it would be a solution to leave the callback there and combine it with you enhencement (ConnectivityHelper)..

@Oliver-Zimmerman
Copy link
Contributor Author

@BMItter I put the registerNetworkCallback within the ConnectivityHelper check and this now seems to be working as expected.

ralfgehrer
ralfgehrer previously approved these changes Oct 12, 2020
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@BMItr
Copy link
Contributor

BMItr commented Oct 12, 2020

lgtm. quicktest on Android 10,11 passed.

@ralfgehrer ralfgehrer merged commit a2007bd into release/1.5.x Oct 12, 2020
@ralfgehrer ralfgehrer deleted the fix/3152-country-list-bug branch October 12, 2020 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants