This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Homescreen Notifications, even though keys were submitted (EXPOSUREAPP-3181, EXPOSUREAPP-3182) #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck for finished submission Signed-off-by: Kolya Opahle <k.opahle@sap.com>
kolyaopahle
added
backend
harambasicluka
changed the title
3 tasks
ralfgehrer
reviewed
Oct 26, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/LocalData.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Oct 26, 2020
| @@ -89,13 +89,18 @@ class DiagnosisTestResultRetrievalPeriodicWorker( | |||
| * @see TestResult | |||
| */ | |||
| private fun initiateNotification(testResult: TestResult) { | |||
| if (LocalData.isTestResultNotificationSent() || LocalData.submissionWasSuccessful()) { | |||
There was a problem hiding this comment.
afaik this is not possible as return if always requires an else branch
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
harambasicluka
approved these changes
Oct 27, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
harambasicluka
deleted the
fix/3182-3181-notifications-in-invalid-states
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a few additional checks to the test result fetching and risk level calculation tasks to check for prior test submission and stops the notification when tests have been submitted already.