Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Show current env when launching app (DEV) #1515

Merged
merged 5 commits into from Nov 3, 2020
Merged

Show current env when launching app (DEV) #1515

merged 5 commits into from Nov 3, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Nov 2, 2020

When testing or setting something up, we spend a lot of time (too much time) going back and forth to make sure we are on the right environment.

This PR adds a toast message on deviceForTester builds that shows us the current environment.

How to test

  • Check that the environments are displayed only for deviceForTesters.
  • Check that switching the environments causes the toast message to change.

@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers do not merge labels Nov 2, 2020
@d4rken d4rken requested a review from a team November 2, 2020 11:59
AndroidMedaGalaxy
AndroidMedaGalaxy previously approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@AndroidMedaGalaxy AndroidMedaGalaxy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the actual device
LGTM \(◦'⌣'◦)/

@harambasicluka harambasicluka added this to the 1.7.0 milestone Nov 2, 2020
BMItr
BMItr previously approved these changes Nov 2, 2020
View reviewed changes
@d4rken d4rken dismissed stale reviews from BMItr and AndroidMedaGalaxy via 0ab2a6c November 2, 2020 17:43
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

61.5% 61.5% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 6f75176 into release/1.7.x Nov 3, 2020
@d4rken d4rken deleted the feature/show-current-env-when-launching-app branch November 3, 2020 11:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMItr BMItr BMItr left review comments

@AndroidMedaGalaxy AndroidMedaGalaxy AndroidMedaGalaxy left review comments

Assignees
No one assigned
Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@d4rken @BMItr @AndroidMedaGalaxy @harambasicluka @ralfgehrer