This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Risk change dialog pops up after being dismissed (EXPOSUREAPP-3536) #1518
Merged
harambasicluka
merged 5 commits into
release/1.6.x
from
fix/3536-risk-change-dialog-pops-up-after-being-dismissed
Nov 3, 2020
Merged
Risk change dialog pops up after being dismissed (EXPOSUREAPP-3536) #1518
harambasicluka
merged 5 commits into
release/1.6.x
from
fix/3536-risk-change-dialog-pops-up-after-being-dismissed
Nov 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uldn't be updated in the future
SamuraiKek
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Nov 2, 2020
Removed unnecessary file.
AlexanderAlferov
previously approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with steps in PR description.
Smoke tested.
lgtm
BMItr
previously approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks clean to me and good to read 👌
harambasicluka
suggested changes
Nov 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I think the Project.xml shouldn't be part this PR.
harambasicluka
changed the title
Risk change dialog pops up after being dismissed - fix (EXPOSUREAPP-3536)
Risk change dialog pops up after being dismissed (EXPOSUREAPP-3536)
Nov 3, 2020
SamuraiKek
dismissed stale reviews from BMItr and AlexanderAlferov
via
November 3, 2020 09:02
f224316
harambasicluka
approved these changes
Nov 3, 2020
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
AlexanderAlferov
approved these changes
Nov 3, 2020
harambasicluka
deleted the
fix/3536-risk-change-dialog-pops-up-after-being-dismissed
branch
November 3, 2020 09:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the LiveData from the VM wasn't getting updated anymore, causing a dialog to show up every time you traveled to another screen and then returned.
Issue was caused by LiveData being filtered and once it had a value, the filter was ignoring any other state the LiveData could be in.
How to quickly test:
In RiskLevelTransaction, comment out the start() function and replace it with this one: