Fix/satisfy pipeline - gradle def function (EXPSOUREAPP-2572) #1519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Corona-Warn-App/build.gradle
Outdated
@@ -162,6 +161,7 @@ android { | |||
variant.buildConfigField "String", "ENVIRONMENT_TYPE_DEFAULT", "\"${flavor.envTypeDefault[typeName]}\"" | |||
|
|||
if (flavor.name == "deviceForTesters") { | |||
buildConfigField "String", "GIT_COMMIT_SHORT_HASH", "\"${getHash()}\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the specific error message?
If this just should be set for specific versions, it should probably be variant.buildConfigField
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal pipeline: A problem occurred starting process 'command 'git''
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefixed variant.
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
This PR addresses a small issue where circle CI failed on building a specific flavor.
FIX
moved getHash Definition to deviceForTesters BuildFlavor.