Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix/satisfy pipeline - gradle def function (EXPSOUREAPP-2572) #1519

Merged
merged 3 commits into from Nov 3, 2020

Conversation

BMItr
Copy link
Contributor

@BMItr BMItr commented Nov 2, 2020

This PR addresses a small issue where circle CI failed on building a specific flavor.

FIX

moved getHash Definition to deviceForTesters BuildFlavor.

@BMItr BMItr requested a review from a team November 2, 2020 20:41
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BMItr BMItr changed the title Fix/satisfy circle ci gradle function (EXPSOUREAPP-2572) Fix/satisfy pipeline - gradle def function (EXPSOUREAPP-2572) Nov 2, 2020
@AlexanderAlferov AlexanderAlferov added the maintainers Tag pull requests created by maintainers label Nov 2, 2020
@@ -162,6 +161,7 @@ android {
variant.buildConfigField "String", "ENVIRONMENT_TYPE_DEFAULT", "\"${flavor.envTypeDefault[typeName]}\""

if (flavor.name == "deviceForTesters") {
buildConfigField "String", "GIT_COMMIT_SHORT_HASH", "\"${getHash()}\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the specific error message?

If this just should be set for specific versions, it should probably be variant.buildConfigField?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal pipeline: A problem occurred starting process 'command 'git''

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefixed variant.

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@BMItr BMItr merged commit 3ef2610 into release/1.7.x Nov 3, 2020
@BMItr BMItr deleted the fix/satisfy-circleCI-gradle-function branch November 3, 2020 10:04
@harambasicluka harambasicluka added this to the 1.7.0 milestone Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants