Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Update the dispatch screen (EXPOSUREAPP-3730) #1613

Merged
merged 9 commits into from
Nov 24, 2020
Merged

Update the dispatch screen (EXPOSUREAPP-3730) #1613

merged 9 commits into from
Nov 24, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

Description

Dispatcher screen and text adjustments as provided in Figma designs.

Steps to reproduce

Go to dispatcher screen and admire the awesome new design...

Closes JIRA ticket EXPOSUREAPP-3730

@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team November 16, 2020 12:42
@Oliver-Zimmerman Oliver-Zimmerman added maintainers Tag pull requests created by maintainers text change PRs with text changes. enhancement Improvement of an existing feature labels Nov 16, 2020
@Oliver-Zimmerman Oliver-Zimmerman added this to the 1.9.0 milestone Nov 16, 2020
janetback
janetback previously approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA approved.

@chiljamgossow chiljamgossow self-assigned this Nov 16, 2020
chiljamgossow
chiljamgossow previously approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to (tested on emulator)

@svengabr svengabr moved this from Initial to Pull Requests in [CM] cwa-app-android Nov 17, 2020
janetback
janetback previously approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

d4rken
d4rken suggested changes Nov 19, 2020
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small padding issue, besides that, looks good.

Corona-Warn-App/src/main/res/layout/include_submission_dispatcher.xml Show resolved Hide resolved
@d4rken d4rken self-assigned this Nov 19, 2020
ralfgehrer
ralfgehrer approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on Pixel (Android 10)

@ralfgehrer ralfgehrer self-assigned this Nov 24, 2020
AndroidMedaGalaxy
AndroidMedaGalaxy approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@AndroidMedaGalaxy AndroidMedaGalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Approved \( ﾟヮﾟ)/

@Diapolo
Copy link

Diapolo commented Nov 24, 2020

Description

Dispatcher screen and text adjustments as provided in Figma designs.

Steps to reproduce

Go to dispatcher screen and admire the awesome new design...

Closes JIRA ticket EXPOSUREAPP-3730

Just an idea/suggestion for regular watchers of this repo: add some screenshots for changed UI elements in general :).

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@d4rken d4rken merged commit 143420c into release/1.9.x Nov 24, 2020
@d4rken d4rken deleted the feature/3730-dispatcher-changes branch November 24, 2020 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralfgehrer ralfgehrer ralfgehrer approved these changes

@d4rken d4rken d4rken approved these changes

@AndroidMedaGalaxy AndroidMedaGalaxy AndroidMedaGalaxy approved these changes

@chiljamgossow chiljamgossow chiljamgossow left review comments

@janetback janetback janetback left review comments

@SabineLoss SabineLoss Awaiting requested review from SabineLoss

Assignees

@ralfgehrer ralfgehrer

@d4rken d4rken

@chiljamgossow chiljamgossow

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Oliver-Zimmerman @Diapolo @ralfgehrer @d4rken @chiljamgossow @AndroidMedaGalaxy @janetback