This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Persist consent to key submission (EXPOSUREAPP-3734) #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiljamgossow
changed the title
harambasicluka
changed the title
|
The comments from this PR #1610 are not all addressed in this PR, are they? |
Yes they will be |
d4rken
suggested changes
Nov 19, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/submission/SubmissionSettings.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/SubmissionRepository.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/SubmissionRepository.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/SubmissionRepository.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentModule.kt
Outdated
Show resolved
Hide resolved
|
Taking the right direction, converting this to draft though as it currently crashes when opening, likely due to the changes to injection. Let's have a short sync call when you have time. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of closed PR
Creates new SubmissionSettings class which persists if the user has given consent for the submission of keys
Refactoring of SubmissionRepository and SubmissionService to enable DI via constructor