Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix RiskLevelCalculationTask not being executed if no new match was found (EXPOSUREAPP-3849) #1657

Merged

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Nov 18, 2020

The RiskLevelCalculationTask was not being executed if the provided key files didn't result in a new exposure summary state.

For some reasons this was not a visible issue before, but unrelated changes have made this issue visible now.

Testing

  • Fresh install (time set in the past)
  • Card is grey
  • Timetravel exactly 1 day
  • Card is green!

@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first. labels Nov 18, 2020
@d4rken d4rken added this to the 1.7.0 milestone Nov 18, 2020
@d4rken d4rken requested a review from a team November 18, 2020 16:24
…en-if-no-match

# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/TracingRepository.kt

fun Throwable.report(
exceptionCategory: ExceptionCategory,
prefix: String?,
suffix: String?
) {
reportProblem(tag = prefix, info = suffix)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

41.3% 41.3% Coverage
0.0% 0.0% Duplication

@d4rken d4rken changed the title Fix RiskLevelCalculationTask not being executed if no new match was found Fix RiskLevelCalculationTask not being executed if no new match was found (EXPOSUREAPP-3849) Nov 18, 2020
@harambasicluka harambasicluka self-assigned this Nov 18, 2020
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ralfgehrer ralfgehrer merged commit c965b28 into release/1.7.x Nov 18, 2020
@ralfgehrer ralfgehrer deleted the fix/3849-execute-riskcalculation-even-if-no-match branch November 18, 2020 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants