This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 499
Use key package day/hour to determine data staleness (EXPOSUREAPP-4042) #1748
Merged
harambasicluka
merged 7 commits into
release/1.8.x
from
fix/4042-error-when-exiting-app-during-download
Nov 30, 2020
Merged
Use key package day/hour to determine data staleness (EXPOSUREAPP-4042) #1748
harambasicluka
merged 7 commits into
release/1.8.x
from
fix/4042-error-when-exiting-app-during-download
Nov 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eset functionality.
…r the key pkgs are outdated when calculating the risk level.
d4rken
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Nov 27, 2020
chris-cwa
reviewed
Nov 30, 2020
defined threshold because [UNKNOWN_RISK_INITIAL] overrules [UNKNOWN_RISK_OUTDATED_RESULTS] */ | ||
return (timeSinceLastDiagnosisKeyFetchFromServer.millisecondsToHours() > | ||
TimeVariables.getMaxStaleExposureRiskRange() && isActiveTracingTimeAboveThreshold()).also { | ||
private suspend fun areKeyPkgsOutDated(nowUTC: Instant): Boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
chris-cwa
approved these changes
Nov 30, 2020
chris-cwa
approved these changes
Nov 30, 2020
BMItr
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already deep checked last friday.
code lgtm.
card issue will probably be solved with #1751 .
As this issue is unrelated a little here,.. approved
Kudos, SonarCloud Quality Gate passed! |
harambasicluka
deleted the
fix/4042-error-when-exiting-app-during-download
branch
November 30, 2020 14:53
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Do some time traveling. If you time travel 48h past the last time for which packages are available, we display the error state card. "Risiko-Ermittlung nicht möglich".