Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Submission Flow: Positive test result with given user consent (EXPOSUREAPP-3680) #1761

Merged
merged 31 commits into from
Dec 2, 2020
Merged

Submission Flow: Positive test result with given user consent (EXPOSUREAPP-3680) #1761

merged 31 commits into from
Dec 2, 2020

Conversation

Oliver-Zimmerman
Copy link
Contributor

@Oliver-Zimmerman Oliver-Zimmerman commented Nov 29, 2020 •
edited

Description

PR for the flow from the positive test result screen with given user consent for key sharing. If the user has provided consent, they will be brought to this screen on receiving a positive test result.

  • Created ViewModel
  • Created Fragment
  • Created Fragment Module
  • Created Custom View for Test Result Section (Card)
  • Adjusted layouts that previously used the includes to now use the Custom View
  • Added relevant DE strings and blank placeholders in standard strings.xml
  • Created Unit and Instrumentation tests.

To-do:
Align with other submission refactoring tickets in terms of navigation after merge in 1.9

Screenshot_20201130-163822_CWA TEST

@Oliver-Zimmerman
XML view created, TestResult custom view started.
8eb74d3
@Oliver-Zimmerman
Created Custom View, adjusted layout to implement custom view, create…
3c08e38 
…d required declared stylables.
@Oliver-Zimmerman
Changed TestResultCard view, less code and achieves the same result.
1017cc5
@Oliver-Zimmerman
Rename custom view to Section instead of Card to avoid confusion with…
60cac62 
… existing views
@Oliver-Zimmerman
Forgot to convert implementation to section rather than card, updated…
a4dd07a 
… accessibility event call
@Oliver-Zimmerman
lint fixes
132e243
@Oliver-Zimmerman
More lint, removed unused import
df24146
@Oliver-Zimmerman
Detekt changes
9fd51fb
@Oliver-Zimmerman
Change getString to getText
727efab
@Oliver-Zimmerman
Added Setter for TestResultSection to set details - included formatti…
8a04233 
…ng functions.
@Oliver-Zimmerman
Lint and Detekt fixes
3f31186
@Oliver-Zimmerman
Merge branch 'release/1.9.x' into feature/3744-test-result-screen
c4cfe5c
@Oliver-Zimmerman
Cleanup of uiState uasge in Custom View formatters/setters after merge
a8f7c7e
@Oliver-Zimmerman
Adjustment to fragment layout, added strings for header
c7cfb0f
@Oliver-Zimmerman
Added remaining strings, implemented TextViews within view
d43e0a7
@Oliver-Zimmerman
Removed progress bar.
8311a1f
@Oliver-Zimmerman
Set up Fragment / ViewModel / Module and added empty String for trans…
38cc02d 
…lation
@Oliver-Zimmerman
Added UI State to ViewModel for TestResultSection formatting. Finaliz…
7b48c6d 
…ed fragment. Updated navigation
@Oliver-Zimmerman
Lint formatting and Detekt changes
2a0cb2b
@Oliver-Zimmerman
Removed unused imports
15fbcba
@Oliver-Zimmerman
Detekt - Line length issue.
a0dc215
@Oliver-Zimmerman
Began Unit and Instrumentation Tests
17ee1c7
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Nov 30, 2020
@harambasicluka harambasicluka added this to the 1.9.0 milestone Nov 30, 2020
@Oliver-Zimmerman Oliver-Zimmerman added enhancement Improvement of an existing feature text change PRs with text changes. labels Nov 30, 2020
@Oliver-Zimmerman Oliver-Zimmerman marked this pull request as ready for review November 30, 2020 16:55
@Oliver-Zimmerman Oliver-Zimmerman requested a review from a team November 30, 2020 16:55
janetback
janetback previously approved these changes Nov 30, 2020
View reviewed changes
@chiljamgossow chiljamgossow self-assigned this Dec 1, 2020
chiljamgossow
chiljamgossow previously approved these changes Dec 1, 2020
View reviewed changes
AndroidMedaGalaxy
AndroidMedaGalaxy approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@AndroidMedaGalaxy AndroidMedaGalaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

janetback
janetback approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
8.4% 8.4% Duplication

@Oliver-Zimmerman Oliver-Zimmerman merged commit f00bde0 into release/1.9.x Dec 2, 2020
@Oliver-Zimmerman Oliver-Zimmerman deleted the feature/3744-test-result-screen branch December 2, 2020 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndroidMedaGalaxy AndroidMedaGalaxy AndroidMedaGalaxy approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@janetback janetback janetback approved these changes

@chiljamgossow chiljamgossow chiljamgossow left review comments

@SabineLoss SabineLoss Awaiting requested review from SabineLoss

Assignees

@chiljamgossow chiljamgossow

@AndroidMedaGalaxy AndroidMedaGalaxy

@AlexanderAlferov AlexanderAlferov

Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Oliver-Zimmerman @chiljamgossow @AndroidMedaGalaxy @AlexanderAlferov @janetback @harambasicluka @ralfgehrer